Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #1147

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Accessibility #1147

merged 5 commits into from
Nov 14, 2023

Conversation

astuanax
Copy link
Contributor

@astuanax astuanax commented Nov 2, 2023

✨ Pull Request

📓 Referenced Issue

#1075 Accessibility simulator menu

ℹ️ About the PR

This PR adds a menu, dropdown, to apply XSLT filters to one of the webviews to simulate the experience of people with visual impairments and color deficiencies.

Things to consider:

  • Size of the menu and icons (long? had to remove overflow-hidden on the webview element)
  • Should we apply it to all screens? (How to do that??)
  • Looking forward to the comments.

🖼️ Testing Scenarios / Screenshots

The menu can be applied to any websites.
Here is a video on how to test:

Peek.2023-10-27.18-58.mp4

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this, but this is fantastic! 🔥

Just a minor comment on the UX and some tweaks for the drop down would make it ready for a release. These UX things, I can take care of if you don't mind.

desktop-app/src/renderer/store/features/renderer/index.ts Outdated Show resolved Hide resolved
@manojVivek
Copy link
Collaborator

@astuanax I have some commits (improvements we discussed) made on top of this PR, but I'm unable to push those to your branch (permission issues?).

So, I'll merge this PR and then raise a new PR with my branch.

@manojVivek manojVivek merged commit f1d8a03 into responsively-org:main Nov 14, 2023
3 checks passed
Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astuanax Thank you so much for contributing this! Looking forward to more! 🎉

@manojVivek
Copy link
Collaborator

@all-contributors Please add @astuanax for code.

Copy link
Contributor

@manojVivek

I've put up a pull request to add @astuanax! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants