Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Add footer, matching functionality of header #813

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

cgarwood
Copy link
Collaborator

@cgarwood cgarwood commented Jan 19, 2022

Adds a global footer, with functionality that matches the header.

Looks like vscode or the pre-commit hook re-formatted a bunch of main.less 🙁

Haven't contributed to this project in a few years (the pre-rollup days) so please let me know if anything needs adjusted.

@rchl
Copy link
Collaborator

rchl commented Jan 19, 2022

I've extracted your formatting changes and committed as f0ccc11
Could you rebase your changes now?

@rchl
Copy link
Collaborator

rchl commented Jan 19, 2022

This needs to be documented in the readme. Otherwise the feature doesn't exist to anyone else. :)

styles/main.less Show resolved Hide resolved
@cgarwood
Copy link
Collaborator Author

Thanks for the review! I think all the comments are addressed now 🙂

styles/main.less Outdated Show resolved Hide resolved
styles/themes.less Outdated Show resolved Hide resolved
@rchl
Copy link
Collaborator

rchl commented Feb 3, 2022

Sorry about the delay, it feel off my radar.

Will merge and release new version ASAP.

@rchl rchl merged commit 4cbd6d3 into resoai:master Feb 3, 2022
@cgarwood
Copy link
Collaborator Author

cgarwood commented Feb 4, 2022

Thanks!

@cgarwood cgarwood deleted the add_footer branch February 4, 2022 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants