This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 279
Scripts with same id overwrite background #425
Comments
I believe, the background is cached in the state entity, and not in the tile item. Try changing that line to TileBoard/scripts/controllers/main.js Line 415 in 538d00a
Now, the question is why this is how it is. I'd suspect it is just a coincidence and most re-appearances of this piece of code could be changed in the way to use |
@akloeckner Yes, changing that line fixed the issue, thanks! Will this result in a fix eventually? |
Makes sense to change that IMO. |
This was referenced Sep 26, 2020
akloeckner
added a commit
to akloeckner/TileBoard
that referenced
this issue
Oct 12, 2020
this change also makes this the default for a few other funtions, namely sliders. fixes resoai#425 BREAKING CHANGE: The order of attrs and def is changed for a few sliders. This should not normally be a problem, because user would only use one of the possibilities. But... just to give note on that.
akloeckner
added a commit
to akloeckner/TileBoard
that referenced
this issue
Oct 12, 2020
rchl
pushed a commit
that referenced
this issue
Oct 12, 2020
Fix released in https://github.com/resoai/TileBoard/releases/tag/v2.0.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have a bunch of tiles that call the same script, as follows:
Clicking these launch the script with different variable values, this works as expected. However, both tiles show the same background image radioparadise.png. When changing the id of the second tile, the background is then respected (demoscene.png is shown for the second tile).
The text was updated successfully, but these errors were encountered: