fix: correct email batch api call with reply_to #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update version from 4.1.1 to 4.2.0 - fix /emails/batch api call to use reply_to instead of replyTo - refactor email transformation using parseEmailToAPIOptions in batch and emails - export Attachment interface in create-email-options.interface.ts
bukinoshita
reviewed
Jan 23, 2025
bukinoshita
reviewed
Jan 23, 2025
bukinoshita
reviewed
Jan 23, 2025
bukinoshita
reviewed
Jan 23, 2025
bukinoshita
reviewed
Jan 23, 2025
bukinoshita
reviewed
Jan 23, 2025
- changed version from 4.2.0 to 4.1.1 in package.json
- updated type import in batch.ts - modified interface name in email-api-options.interface.ts - adjusted function return type in parse-email-to-api-options.ts
…eEmailToApiOptions - updated function name in imports across multiple files - modified function name in test cases - ensured consistent naming convention throughout the codebase
- change describe block to use correct camelCase for function name
bukinoshita
approved these changes
Jan 23, 2025
vcapretz
approved these changes
Jan 23, 2025
|
It would be nice to update the docs, everything still references |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421
Using this implementation ↓
We were getting this behavior when replying an email ↓
But it should reply to
delivered@resend.devinstead.After fixing it, this is what we get ↓
Correctly mapping the Node.js SDK's fields to Resend's API so we do not forget any option in the payload.