feat: Add missing fields to the GetEmailResponse type
#146
+204
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukinoshita
changed the title
GetEmailResponse type
|
can you run |
bukinoshita
reviewed
Aug 15, 2023
bukinoshita
approved these changes
Aug 15, 2023
bukinoshita
changed the title
GetEmailResponse typeGetEmailResponse type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in the API documentation, the
GetEmailResponsetype is missing some fields that are useful to access. (Side note: the API docs appear to be wrong in that thebcc, cc, reply_tofields do returnnulland not the advertised[null]).This PR adds those missing fields.
It also seems that the API returns fields with
null, rather than omitting them or with the valueundefined, so this PR also updates the types to match this behaviour.A small addition fix is that the GetEmailResponse type is now exported in the
index.ts.Please feel free to point out any issues or things that I may have failed to consider in this PR.