fix: Ensure either text or html is a required field
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukinoshita
changed the title
bukinoshita
changed the title
text or html is a required field
bukinoshita
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
CreateEmailOptionstype to ensure eithertextorhtmlis set for the email payload to be valid.This will ensure that either
CreateEmailWithHtmlOptionsorCreateEmailWithTextOptionsis required. This change also allows bothhtml&textto be used at the same time.This PR also updates the tests to ensure that any mock tests without
htmlortextcontain either on of the fields.