Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(render): Browser version of react-dom/server being used on Next.js' Edge #1747

Draft
wants to merge 3 commits into
base: canary
Choose a base branch
from
Draft

fix(render): Browser version of react-dom/server being used on Next.js' Edge #1747

wants to merge 3 commits into from
+330 −91

Conversation

gabrielmfern
Copy link
Collaborator

@gabrielmfern gabrielmfern commented Oct 28, 2024 •
edited
Loading

This is required for #1630 but still breaks due to vercel/next.js#71865

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:02pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 8:02pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 87e2a73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabrielmfern gabrielmfern changed the title fix(render): Make a separate function to attempt importing from edge first fix(render): Changes for proper support of NextJS's edge Oct 28, 2024
@gabrielmfern gabrielmfern self-assigned this Oct 28, 2024
@gabrielmfern gabrielmfern force-pushed the canary branch 4 times, most recently from 0426d02 to 868acde Compare November 5, 2024 19:07
@gabrielmfern gabrielmfern changed the title fix(render): Changes for proper support of NextJS's edge fix(render): Browser version of react-dom/server being used on Next.js' Edge Nov 13, 2024
@gabrielmfern gabrielmfern force-pushed the canary branch 2 times, most recently from 4ee4d1d to 0187b0a Compare December 23, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabrielmfern gabrielmfern

Labels
Package: @react-email/render
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrielmfern