Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump npm version #1743

Merged
merged 4 commits into from
May 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ bin/setenv.*
/webofneeds/won-matcher-webapp/overlays
/webofneeds/won-owner-webapp/src/main/webapp/node
/webofneeds/won-owner-webapp/src/main/webapp/node_modules
/webofneeds/won-owner-webapp/src/main/webapp/package-lock.json
/webofneeds/won-owner-webapp/src/main/webapp/yarn.lock
/webofneeds/won-owner-webapp/src/main/webapp/yarn-error.log
/webofneeds/won-owner-webapp/src/main/webapp/.tern-project
Expand Down
1 change: 1 addition & 0 deletions documentation/build-with-eclipse.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
* Open Window → Preferences → General → Keys and select the scheme "Intellij Idea".
11. Change "spaces for tabs" settings: Window >> Preferences >> General >> Editors >> Text Editors >> Check "Insert spaces for tabs"
12. Set maven profiles: right-click the webofneeds project in the package explorer >> Maven >> Select Maven Profiles. check 'skip-tests'
13. If you develop on Windows you will need to setup `node`s `windows-build-tools` (see [this guide](./installation-setting-up-frontend-development-environment.md#installing-windows-build-tools-on-windows))

### Tomcat integration:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,21 @@

### Setting up Frontend Development Environment for Windows (AngularJS)

#### Installing Node

1. Goto <http://nodejs.org/download/> and download the NodeJS version you need.<br>
2. install NodeJS<br>
3. make sure that NodeJS is correctly installed by opening a Windows Command Console and typing `node -v` then enter. If it didn't work, check whether or not your node-directory are in your system-path-variable<br>
4. Windows users need to install msygit(http://msysgit.github.io/) with the right option. see the bower installation instruction for the right option. Windows users will also need to run `npm install -g windows-build-tools` (otherwise building sass might fail later with a message about not finding VCBuild.exe. the command will install a python-environment and dotnet)
5. the maven install task will download and install bower and jspm for you that in turn will be used to install the owner-apps dependencies. However maven isn't yet configured to run `jspm install` as there's no easy integration via maven-frontend as with npm.

Tip: if you get the error "err Registry bower not found", you need to execute the following two commands:
```
cd webofneeds/won-owner-webapp/src/main/webapp/
./node_modules/.bin/jspm registry create bower jspm-bower-endpoint
```
If that fails with the follwing error:
```
err Registry handler jspm-bower-endpoint not installed.
```
Then you first need to install jspm-bower-endpoint:
```
npm install jspm-bower-endpoint
```
#### Installing Windows Build Tools on Windows

Windows users will need to run `npm install -g windows-build-tools` (otherwise building `node-sass` and `rdf-canonize` might fail later with a message about not finding VCBuild.exe. the command will install a python-environment and dotnet)

Tip: if the owner webapp is missing a lot of js files (look into the browser's js console and network tools), jspm didn't download the js dependencies.
Go to `webofneeds/webofneeds/won-owner-webapp/src/main/webapp` and run `node_modules/jspm/jspm.js install`
If your Windows User does not have admin permissions, installing `windows-build-tools` with an admin user will unfortunately install them only for that user. (Further info at https://github.com/researchstudio-sat/webofneeds/pull/1743) The Visual Studio build tools are installed correctly however, so you only need to fix your Python installation.

1. Go to https://www.python.org/downloads/ and download and install Python 2.7 (Python 3 will not work!)
2. Locate your Python installation (your `python.exe`), we will call this path `$PATH_TO_PYTHON_EXE`
3. Run `npm config set python $PATH_TO_PYTHON_EXE` to update the python location

<!--
### Building with IntelliJ
Expand Down
4 changes: 2 additions & 2 deletions webofneeds/won-owner-webapp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@
<!-- optional: default phase is "generate-resources" -->
<phase>initialize</phase>
<configuration>
<nodeVersion>v7.1.0</nodeVersion>
<npmVersion>4.4.4</npmVersion>
<nodeVersion>v10.1.0</nodeVersion>
<npmVersion>6.0.1-next.0</npmVersion>
</configuration>
</execution>
<execution>
Expand Down
Loading