Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Eslint and add Prettier #1274

Closed
wants to merge 5 commits into from
Closed

Conversation

ewan-escience
Copy link
Collaborator

Upgrade Eslint and add Prettier

Changes proposed in this pull request:

  • Upgrade Eslint from 8.46.0 to 9.9.0 in the frontend
  • Setup Prettier for the frontend

How to test:

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
  • Check if everything still works
  • Read the added documentation in frontend/README.md
  • Check out the config file frontend/eslint.config.js (and the removed file frontend/.eslintrc.json)
  • Check out the config files frontend/.prettierrc and frontend/.prettierignore

Closes #1198
Related to #915

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Aug 16, 2024
@ewan-escience
Copy link
Collaborator Author

@dmijatovic can you fix the broken workflow? Maybe this or this can help.

@dmijatovic
Copy link
Contributor

@ewan-escience Unfortunately next eslint config does not support eslint v9.

We should wait for a new release of eslint-config-next plugin that supports eslint v9.x.

@ewan-escience
Copy link
Collaborator Author

Closing this, as this branch will be very behind when Next.js will support Eslint 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade eslint naar v9 and setup prettier
2 participants