Fix tests of duplicated packages in Dynamic import #6191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mununki
commented
Apr 23, 2023
| print_if_pipe ppf Clflags.dump_rawlambda Printlambda.lambda lambda | ||
| |> Lam_compile_main.compile outputprefix module_system exports | ||
| |> Lam_compile_main.compile outputprefix NodeJS exports |
There was a problem hiding this comment.
Temporarily I removed the argument module_system to do eager evaluation here and pass NodeJS instead, then tests are passed.
This is not the cure for the root cause, Lam_compile.compile needs to know the module_system info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the tests: duplicated symlinked tests, transitive pinned packages