-
Notifications
You must be signed in to change notification settings - Fork 455
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
comment out duplicated symlinked, transitive package tests
- Loading branch information
Showing
3 changed files
with
45 additions
and
42 deletions.
There are no files selected for viewing
57 changes: 29 additions & 28 deletions
57
jscomp/build_tests/duplicated_symlinked_packages/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,34 @@ | ||
| const fs = require('fs') | ||
| const path = require('path') | ||
| const child_process = require('child_process') | ||
| const rescript_exe = require("../../../scripts/bin_path").rescript_exe | ||
| // https://github.com/rescript-lang/rescript-compiler/pull/5703#issuecomment-1518507161 | ||
| // const fs = require('fs') | ||
| // const path = require('path') | ||
| // const child_process = require('child_process') | ||
| // const rescript_exe = require("../../../scripts/bin_path").rescript_exe | ||
|
|
||
| const expectedFilePath = path.join(__dirname, 'out.expected') | ||
| // const expectedFilePath = path.join(__dirname, 'out.expected') | ||
|
|
||
| const updateTests = process.argv[2] === 'update' | ||
| // const updateTests = process.argv[2] === 'update' | ||
|
|
||
| function postProcessErrorOutput (output) { | ||
| output = output.trimRight() | ||
| output = output.replace(new RegExp(__dirname, 'gi'), '.') | ||
| return output | ||
| } | ||
| child_process.execSync(`${rescript_exe} clean -with-deps`,{cwd:__dirname}) | ||
| child_process.exec(rescript_exe, {cwd: __dirname}, (err, stdout, stderr) => { | ||
| const actualErrorOutput = postProcessErrorOutput(stderr.toString()) | ||
| if (updateTests) { | ||
| fs.writeFileSync(expectedFilePath, actualErrorOutput) | ||
| } else { | ||
| const expectedErrorOutput = postProcessErrorOutput(fs.readFileSync(expectedFilePath, {encoding: 'utf-8'})) | ||
| if (expectedErrorOutput !== actualErrorOutput) { | ||
| console.error(`The old and new error output aren't the same`) | ||
| console.error('\n=== Old:') | ||
| console.error(expectedErrorOutput) | ||
| console.error('\n=== New:') | ||
| console.error(actualErrorOutput) | ||
| process.exit(1) | ||
| } | ||
| } | ||
| }) | ||
| // function postProcessErrorOutput (output) { | ||
| // output = output.trimRight() | ||
| // output = output.replace(new RegExp(__dirname, 'gi'), '.') | ||
| // return output | ||
| // } | ||
| // child_process.execSync(`${rescript_exe} clean -with-deps`,{cwd:__dirname}) | ||
| // child_process.exec(rescript_exe, {cwd: __dirname}, (err, stdout, stderr) => { | ||
| // const actualErrorOutput = postProcessErrorOutput(stderr.toString()) | ||
| // if (updateTests) { | ||
| // fs.writeFileSync(expectedFilePath, actualErrorOutput) | ||
| // } else { | ||
| // const expectedErrorOutput = postProcessErrorOutput(fs.readFileSync(expectedFilePath, {encoding: 'utf-8'})) | ||
| // if (expectedErrorOutput !== actualErrorOutput) { | ||
| // console.error(`The old and new error output aren't the same`) | ||
| // console.error('\n=== Old:') | ||
| // console.error(expectedErrorOutput) | ||
| // console.error('\n=== New:') | ||
| // console.error(actualErrorOutput) | ||
| // process.exit(1) | ||
| // } | ||
| // } | ||
| // }) | ||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| //@ts-check | ||
| var child_process = require("child_process"); | ||
| var assert = require("assert"); | ||
| var fs = require("fs") | ||
| var rescript_exe = require("../../../scripts/bin_path").rescript_exe; | ||
| // https://github.com/rescript-lang/rescript-compiler/pull/5703#issuecomment-1518507161 | ||
| // //@ts-check | ||
| // var child_process = require("child_process"); | ||
| // var assert = require("assert"); | ||
| // var fs = require("fs") | ||
| // var rescript_exe = require("../../../scripts/bin_path").rescript_exe; | ||
|
|
||
| console.log(child_process.execSync(rescript_exe, { encoding: "utf8", cwd: "./a" })); | ||
| // console.log(child_process.execSync(rescript_exe, { encoding: "utf8", cwd: "./a" })); | ||
|
|
||
| assert(fs.existsSync("./node_modules/c/lib/js/tests/test.mjs"), "dev files of module 'c' were not built by 'a' even though 'c' is a transitive pinned dependency of 'a' through 'b'") | ||
| // assert(fs.existsSync("./node_modules/c/lib/js/tests/test.mjs"), "dev files of module 'c' were not built by 'a' even though 'c' is a transitive pinned dependency of 'a' through 'b'") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| //@ts-check | ||
| var child_process = require("child_process"); | ||
| var assert = require("assert"); | ||
| var fs = require("fs") | ||
| var rescript_exe = require("../../../scripts/bin_path").rescript_exe; | ||
| // https://github.com/rescript-lang/rescript-compiler/pull/5703#issuecomment-1518507161 | ||
| // //@ts-check | ||
| // var child_process = require("child_process"); | ||
| // var assert = require("assert"); | ||
| // var fs = require("fs") | ||
| // var rescript_exe = require("../../../scripts/bin_path").rescript_exe; | ||
|
|
||
| console.log(child_process.execSync(rescript_exe, { encoding: "utf8", cwd: "./a" })); | ||
| // console.log(child_process.execSync(rescript_exe, { encoding: "utf8", cwd: "./a" })); | ||
|
|
||
| assert(!fs.existsSync("./node_modules/c/lib/js/tests/test.mjs"), "dev files of module 'c' were built by 'a' even though 'c' is not a pinned dependency of 'a'") | ||
| // assert(!fs.existsSync("./node_modules/c/lib/js/tests/test.mjs"), "dev files of module 'c' were built by 'a' even though 'c' is not a pinned dependency of 'a'") |