Update Bevy to 0.15, update Rerun to 0.20 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arrow length shenanigans related to |
teh-cmc
approved these changes
Dec 10, 2024
| @@ -19,11 +19,10 @@ https://github.com/rerun-io/revy/assets/2910679/cd096cbe-5e68-4acf-8010-e6c32c55 | |||
|
|
|||
| ## Examples | |||
|
|
|||
| |[Breakout](https://github.com/bevyengine/bevy/blob/v0.13.0/examples/games/breakout.rs)|[3D shapes](https://github.com/bevyengine/bevy/blob/v0.13.0/examples/3d/3d_shapes.rs)|[Alien Cake Addict](https://github.com/bevyengine/bevy/blob/v0.13.0/examples/games/alien_cake_addict.rs)| | |||
| |[Breakout](https://github.com/bevyengine/bevy/blob/v0.15.0/examples/games/breakout.rs)|[3D shapes](https://github.com/bevyengine/bevy/blob/v0.15.0/examples/3d/3d_shapes.rs)|[Alien Cake Addict](https://github.com/bevyengine/bevy/blob/v0.15.0/examples/games/alien_cake_addict.rs)| | |||
There was a problem hiding this comment.
Once this is merged, I'll make a release and link to our examples instead, so people can see what the modification actually looks like.
| @@ -254,7 +233,7 @@ impl<C: rerun::LoggableBatch> rerun::ComponentBatch for Aliased<C> {} | |||
|
|
|||
| /// Helper to merge any number of [`rerun::AsComponents`]. | |||
| #[allow(dead_code)] | |||
| pub struct ManyAsComponents(Vec<Box<dyn rerun::AsComponents>>); | |||
| pub struct ManyAsComponents(pub Vec<Box<dyn rerun::AsComponents>>); | |||
There was a problem hiding this comment.
Ooooh, I should add the blanket impls for this
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considered adding blueprints to the example links, but wasn't all that interesting (maybe hide panels, but not much more to be done here)
Performance overall comparable, Rerun 0.20 is generally a little bit faster, but not much here.
What's really annoying though is the invasion of transform arrows: had to turn them off everywhere in a hacky way otherwise things get way to overloaded. Will follow-up over on Rerun about that.
Updated readme (with updated examples) rendered:
https://github.com/rerun-io/revy/blob/update-bevy-and-rerun/README.md