Make Box/AssetVideo/ViewCoordinates/Asset3D eager serialized in Rust
#8785
Conversation
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12927429189 |
| .downcast_ref::<arrow::array::ListArray>() | ||
| .expect("Video blob data is not a ListArray"); |
There was a problem hiding this comment.
Bit unfortunate to risk a panic in a method that already returns a result anyhow?
There was a problem hiding this comment.
agreed, but the problem is that re_video::VideoLoadError ofc knows nothing about any kind of arrow shenanigans we might be dealing with, which means I'd need to change the error type here or leak things into video load error
There was a problem hiding this comment.
You can always have an escape hatch like:
#[error(transparent)]
Other(#[from] anyhow::Error),🤷♂️
Related
Pinholearchetype in Rust eager serialized #8789What
View coordinates comes with some slight api breakage since we can no longer offer constants for the different orientations.
After this, the only archetypes that haven't migrated are: