Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce eager serialization & update/clear APIs in the C++ SDK #8727

Merged
merged 18 commits into from
Jan 21, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 17, 2025

Related

What

Introduces both eager serialization (serialization upon Archetype construction) & update/clear APIs to C++ codegen.
Just like on Rust, we're doing a case by case opt-in right now because there's some extensions & tests that need individual changes. Ported so far are:

  • all blueprint types (they're unused right now)
  • annotation_context
  • arrows2d
  • arrows3d
  • points2d
  • points3d
  • transform3d

everything else still needs porting over


  • passes main ci

Copy link

github-actions bot commented Jan 17, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
207dd98 https://rerun.io/viewer/pr/8727 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf force-pushed the andreas/eager-serialization-cpp branch from 7b90cee to 4118a3d Compare January 17, 2025 16:07
Copy link

github-actions bot commented Jan 17, 2025

Latest documentation preview deployed successfully.

Result Commit Link
207dd98 https://landing-q5e0sibeh-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf force-pushed the andreas/eager-serialization-cpp branch from e6f87d6 to faa48a5 Compare January 17, 2025 16:53
@teh-cmc teh-cmc force-pushed the andreas/eager-serialization-cpp branch from faa48a5 to 41349a0 Compare January 20, 2025 08:56
@teh-cmc
Copy link
Member

teh-cmc commented Jan 20, 2025

just fixing conflicts, dont mind me

@teh-cmc
Copy link
Member

teh-cmc commented Jan 20, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12864376298

@teh-cmc teh-cmc self-requested a review January 21, 2025 08:15
@teh-cmc
Copy link
Member

teh-cmc commented Jan 21, 2025

Note: I had to re-ignore partial updates snippets for C++ on main (because tagging is re-enabled there). This PR should make sure to rebase and re-enable them before merging.

Wumpf added 2 commits January 21, 2025 17:03
this was the behavior prior (via specially adjusted serialization) and is now better documented.
@Wumpf
Copy link
Member Author

Wumpf commented Jan 21, 2025

@rerun-bot full-check

Copy link

@Wumpf
Copy link
Member Author

Wumpf commented Jan 21, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12891779936

@Wumpf Wumpf merged commit e7318f3 into main Jan 21, 2025
71 of 72 checks passed
@Wumpf Wumpf deleted the andreas/eager-serialization-cpp branch January 21, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants