New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port `generic_placeholder_for_datatype` to `arrow-rs` #8628

Merged

emilk merged 5 commits into main from emilk/less-arrow2

Jan 9, 2025

Member

emilk commented Jan 9, 2025 •

edited

Loading

Related

Part of Migrate from re_arrow2 to arrow #3741

cargo test --all-features passes

emilk added 4 commits

January 9, 2025 13:25


          Port ArrowString to arrow-rs

a3308e4


          Port placeholder generation

443797c


          Fix component test

a076074


          Update screenshot of Plane3D placeholder (it's better now!)

324be27

emilk added 🚜 refactor exclude from changelog labels

github-actions bot commented Jan 9, 2025 •

edited by emilk

Loading

Web viewer built successfully. If applicable, you should also test it:

I have tested the web viewer

Result	Commit	Link	Manifest
✅	`c092217`	https://rerun.io/viewer/pr/8628	`+nightly` `+main`

^{Note: This comment is updated whenever you push a commit.}


          Remove unused imports

c092217

Wumpf self-requested a review

January 9, 2025 15:54

Wumpf approved these changes

View reviewed changes

Member

Wumpf left a comment

nice! once somebody figured out all the magic invocation this looks so straight forward 😄
Great to see fixed size arrays placeholders being much better now

emilk merged commit 2ac4490 into main

33 checks passed

emilk deleted the emilk/less-arrow2 branch

January 9, 2025 15:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog 🚜 refactor