Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downcast typo in line visualizers #8579

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix downcast typo in line visualizers #8579

merged 1 commit into from
Jan 6, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 6, 2025

Introduced in the chunk iteration refactoring from a couple hours ago.

image
image

@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself 💣 crash crash, deadlock/freeze, do-no-start exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 5e21054 https://rerun.io/viewer/pr/8579 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc merged commit 9699349 into main Jan 6, 2025
38 of 39 checks passed
@teh-cmc teh-cmc deleted the cmc/downcast_typo branch January 6, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
💣 crash crash, deadlock/freeze, do-no-start exclude from changelog PRs with this won't show up in CHANGELOG.md 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @abey79