Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltips being dragged along in graph view #8573

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Jan 3, 2025

Related

What

This fixes the problem by tying to tooltip position to the node position instead of the the pointer, with the nice side-effect that tooltips can now be interacted with in the graph view.

There is some weirdness with tooltips opening for the tooltips, but we should probably tackle that separately.

image

Copy link

github-actions bot commented Jan 3, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
9e499b4 https://rerun.io/viewer/pr/8573 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@grtlr grtlr merged commit 80bd667 into main Jan 3, 2025
35 checks passed
@grtlr grtlr deleted the grtlr/fix-hover-graph branch January 3, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip moves with the cursor during hovering in graph view
2 participants