Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve view property ui methods #8305

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Dec 3, 2024

Related

What

  • use ViewProperty util construct some more
  • route individual property ui via view_property_component_ui_custom making it easier to draw custom ui for specific view properties while still having all tooltip & extra menus be the same

@Wumpf Wumpf added ui concerns graphical user interface 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
560aa85 https://rerun.io/viewer/pr/8305

Note: This comment is updated whenever you push a commit.

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very handy!

@Wumpf Wumpf merged commit b21bfa5 into main Dec 4, 2024
38 checks passed
@Wumpf Wumpf deleted the andreas/more-composable-components-ui branch December 4, 2024 07:57
grtlr pushed a commit that referenced this pull request Dec 4, 2024
### Related

* split out of #8234 

### What

* use `ViewProperty` util construct some more
* route individual property ui via `view_property_component_ui_custom`
making it easier to draw custom ui for specific view properties while
still having all tooltip & extra menus be the same
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants