Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing seconds/nanoseconds to VideoFrameReference archetype #7833

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Allow passing seconds/nanoseconds to VideoFrameReference archetype #7833

merged 4 commits into from
Oct 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 18, 2024 •
edited by github-actions bot
Loading

What

Also, passing a float directly will trigger a warning now.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added this to the Next patch release milestone Oct 18, 2024
abey79
abey79 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice API improvement

rerun_py/rerun_sdk/rerun/archetypes/video_frame_reference_ext.py Outdated Show resolved Hide resolved
@Wumpf Wumpf removed this from the Next patch release milestone Oct 22, 2024
@Wumpf Wumpf force-pushed the andreas/improve-video-frame-reference-api branch from be221c2 to c6bc61e Compare October 22, 2024 13:05
@Wumpf Wumpf merged commit c23e81e into main Oct 22, 2024
34 checks passed
@Wumpf Wumpf deleted the andreas/improve-video-frame-reference-api branch October 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VideoFrameReference should have an extension constructor for seconds=
2 participants
@Wumpf @abey79