-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a How-to guide for the dataframe API #7727
Conversation
Deployed docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice ⭐
# only keep rows where a position is available for the robot | ||
view = view.filter_is_not_null(rr.dataframe.ComponentColumnSelector("/world/robot", "Position3D")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be so nice if this could be written as
# only keep rows where a position is available for the robot
view = view.filter_is_not_null("/world/robot:Position3D")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the code for this kind of parsing in crates/store/re_log_types/src/path/parse_path.rs
(ComponentPath::from_str
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I started looking into this it got hung up on questions like whether
"world/camera/**:[Image,Transform3D,Pinhole]"
is a legal expression.
"/world/scene": ["Text"], | ||
}) | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm following along with a code editor and at this point I'm wondering a lot what I can do with a view to get data. Should probably go here somewhere
view = view.filter_range_sequence(0, 10) | ||
``` | ||
|
||
This API exists for both temporal and sequence timeline, and for various units: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these should be api links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm maybe not yet because we haven't document all of them that well yet
What
This PR introduces a How-to guid for the dataframe API which includes:
Needs this to pass CI:
lint.py
#7720Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.