Fix image & video cache creating new entries when selecting data without explicit media type #7590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
That lengthy title is best explained in steps:
This happened because image & video both use the media type as part of their cache key entries, but we tend to sometimes resolve it ahead of time and sometimes not, so we get new cache entries.
We do want the media type in the cache entries so we can memorize which (user selected / override affected) media types won't work, but we have to make sure we don't waste memory because of when we resolve the media type.
Before:
before.mp4
After:
after.mp4
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.