Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace host_web_viewer method with WebViewerConfig::host_web_viewer #7553

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 30, 2024

What

This makes it easier to host Rerun webviewer.

Usage example

    rerun::web_viewer::WebViewerConfig {
        source_url: Some(
            "https://app.rerun.io/version/0.18.1/examples/arkit_scenes.rrd".to_owned(),
        ),
        force_wgpu_backend: Some("webgl".to_owned()),
        ..Default::default()
    }
    .host_web_viewer()?
    .block();

This is a followup of this comment #7537 (comment)
Opted to not implement a builder as well since I felt it's not worth the hassle here, above snippet looks perfectly fine without a builder.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested 👍

@Wumpf
Copy link
Member Author

Wumpf commented Oct 1, 2024

Did some via pixi rerun-web, but yeah let's see if we can do some more!

@Wumpf Wumpf added the do-not-merge Do not merge this PR label Oct 1, 2024
Base automatically changed from andreas/expose-hw-sw-decode to main October 1, 2024 07:43
An error occurred while trying to automatically change base from andreas/expose-hw-sw-decode to main October 1, 2024 07:43
@Wumpf Wumpf force-pushed the andreas/improved-rust-webviewerspawn branch from c7fc2f1 to 8bbe340 Compare October 1, 2024 07:44
@Wumpf Wumpf added do-not-merge Do not merge this PR and removed do-not-merge Do not merge this PR labels Oct 1, 2024
@Wumpf Wumpf merged commit 45add8d into main Oct 1, 2024
34 of 39 checks passed
@Wumpf Wumpf deleted the andreas/improved-rust-webviewerspawn branch October 1, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants