Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen reflection API for enums, with docstring for variants #6625

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Codegen reflection API for enums, with docstring for variants #6625

merged 9 commits into from
Jun 25, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 24, 2024 •
edited by github-actions bot
Loading

What

Add tooltips with docstrings for enum variants using codegen+reflection

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 24, 2024
@Wumpf Wumpf self-requested a review June 25, 2024 07:21
Wumpf
Wumpf approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit unfortunate that this doesn't live in reflection. But that would have been way more complex for little gain, so I appreciate the simplicity of this PR

crates/re_edit_ui/src/datatype_editors/enum_combobox.rs Show resolved Hide resolved
@emilk emilk merged commit 68ba0f5 into main Jun 25, 2024
33 of 34 checks passed
@emilk emilk deleted the emilk/enum-variant-reflection branch June 25, 2024 08:09
tfoldi added a commit to tfoldi/rerun that referenced this pull request Jun 25, 2024
@tfoldi
Handle enums differently to support rerun-io#6625
a14d6ab
tfoldi added a commit to tfoldi/rerun that referenced this pull request Jun 25, 2024
@tfoldi
Handle enums differently to support rerun-io#6625
1b5568f
tfoldi added a commit to tfoldi/rerun that referenced this pull request Jun 28, 2024
@tfoldi
Handle enums differently to support rerun-io#6625
dfa514f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tooltips for overrides and defaults as well as for enums
2 participants
@emilk @Wumpf