Generate reflection for archetypes #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
ui
emilk
commented
Jun 24, 2024
emilk
added
the
exclude from changelog
Wumpf
approved these changes
Jun 25, 2024
|
|
||
| let mut code = format!("// {}\n\n", autogen_warning!()); | ||
| code.push_str("#![allow(unused_imports)]\n"); | ||
| code.push_str("#![allow(clippy::too_many_lines)]\n"); |
There was a problem hiding this comment.
huh, news to me that we have this lint active anywhere
There was a problem hiding this comment.
Good! It means you don't often hit our very high function line limit
Line 24 in 7b35938
Comment on lines
+168
to
+169
| let id = egui::Id::new((archetype_name, field.display_name)); | ||
| ui.markdown_ui(id, field.docstring_md); |
There was a problem hiding this comment.
It seems that markdown ui somehow adds a lot of space on top and bottom of the hover ui. Is that intentional? Looks like a bug, orthogonal to this PR
Before:
There was a problem hiding this comment.
It's a bug: lampsitter/egui_commonmark#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ArchetypeFieldInfointo thereflectionmodule #6616Replaces the previous code with the new reflection code.
For now I decided that the archetype reflection is still opt-in (with
attr.rust.generate_field_info) just to reduce the amount of strings bloating our .wasm binary. We can easily change this in the future if we want to.Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.