-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use Python 3.11 in pixi #5365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fairly strong reject on my part. As noted on slack, this can cause lots of issues. For example: this caps mypy to a version that supports 3.8, which might be old, and less stringent than more recent mypy version.
My general rule of thumb:
- lint/format/whatnot with the most recent supported version
- run tests on all supported versions
Ok, I've changed it to always run Python 3.12 in pixi instead, and to run our |
This fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Trying to get |
Went down to 3.11 to get CI green, |
What
We should all use the same Pyhthon version for linting, otherwise we will get different results. For instance, I get 60 errors running
pixi run lint-py-mypy
onmain
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io