-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finer plot aggregation #4998
Finer plot aggregation #4998
Conversation
Size changes
|
Worth checking the before and after performance on the plot-dashboard benchmark script for this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as long as the impact on a plot dashboard is negligible
Test-data:
Parallel tessellation is something I'm working on in a branch on egui. |
Yeah, I think I will roll this back to using full pixel width, thinking especially about retina screens on web. |
4a099c0
to
17721aa
Compare
What
We would previously aggregate the plots over a time-window equal in width to a ui point.
The MinMax aggregator does a zig-zag between min and max, so this causes a very jagged look, especially on high-dpi screens.
With this PR, we switch to using a physical pixels as the default aggregation width, but for MinMax is is half a pixel. This reduces the jaggedness, but does not completely remove it. It comes at a cost though of higher tessellation cost.
I have an idea for how we can throw rayon on the tessellation problem though.
Before
After
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io