-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deadlock playground: disable top-level system exec parallelism #4968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🪳 bug
Something isn't working
💣 crash
crash, deadlock/freeze, do-no-start
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
Jan 30, 2024
teh-cmc
changed the title
Deadlock playground: isable top-level system exec parallelism
Deadlock playground: disable top-level system exec parallelism
Jan 30, 2024
example for a stuck rayon thread:
|
We got what we came for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🪳 bug
Something isn't working
💣 crash
crash, deadlock/freeze, do-no-start
do-not-merge
Do not merge this PR
exclude from changelog
PRs with this won't show up in CHANGELOG.md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this fixes the deadlock from:
The current theory is that the nested layer of parallel iterators on the space view execution path results in rayon tasks being unscheduled while holding a cache lock.
Removing the first layer of parallelism fixes the issue, although I have no idea whether that's the right thing to do (cc @Wumpf).
To reproduce:
On main, that deadlocks instantly when grabbing the cache lock in
rerun/crates/re_query_cache/src/cache.rs
Line 252 in 7923f49
Main thread backtrace
On this branch it should look like this:
24-01-30_12.46.48.patched.mp4
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io