Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting workspace deps to a somewhat better state #2026

Merged
merged 10 commits into from
May 4, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented May 3, 2023

  • Always disable default feature flags for all re_ crates when working within the workspace
  • Make examples independent of workspace shenanigans and easily copy pastable

Fixes #2024 (see over there for more explanations...)

$ cd rerun_py && cargo tree -i re_viewer
re_viewer v0.6.0-alpha.0 (/home/cmc/dev/rerun-io/rerun/crates/re_viewer)
└── rerun v0.6.0-alpha.0 (/home/cmc/dev/rerun-io/rerun/crates/rerun)
    └── rerun_py v0.6.0-alpha.0 (/home/cmc/dev/rerun-io/rerun/rerun_py)

$ cargo tree --no-default-features -i re_viewer
warning: nothing to print.

PR Build Summary: https://build.rerun.io/pr/2026

@teh-cmc teh-cmc added 🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) labels May 3, 2023
@teh-cmc teh-cmc marked this pull request as ready for review May 3, 2023 09:02
@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API labels May 3, 2023
@emilk emilk self-requested a review May 4, 2023 07:07
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we should also add a lint to look for (and forbid) workspace in any example Cargo.toml so we don't regress here

@teh-cmc
Copy link
Member Author

teh-cmc commented May 4, 2023

added workspace deps linter -- expecting clock example to fail CI in 3..2..1...

edit: yeeee
image

@teh-cmc teh-cmc merged commit cd4fa0f into main May 4, 2023
@teh-cmc teh-cmc deleted the cmc/workspace_deps_conendrum branch May 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍💻 dev experience developer experience (excluding CI) 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rerun_py always enables all of rerun's default-flags
2 participants