Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent drag-and-drop behavior: dropping multiple files results in multiple recordings #7965

Closed
emilk opened this issue Oct 31, 2024 · 3 comments · Fixed by #7966
Closed

Inconsistent drag-and-drop behavior: dropping multiple files results in multiple recordings #7965

emilk opened this issue Oct 31, 2024 · 3 comments · Fixed by #7966
Assignees
@teh-cmc
Milestone
0.20 - Maps, H.264

Comments

@emilk
Copy link
Member

emilk commented Oct 31, 2024 •
edited
Loading

Start with the welcome screen. Drag and drop two images into Rerun.

  • If you drag and drop them one at a time, they end up in the same recording (good!)
  • If you drag and drop them both at the same time, you end up with two recordings (bad!)
@emilk emilk added this to the 0.20 - Maps, H.264 milestone Oct 31, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Oct 31, 2024

Haaa, and let me guess: if you drop two of them on top of an open recording, then it does work as expected?

The welcome screen has to recording-id to recommend, so that would make sense.

@teh-cmc
Copy link
Member

teh-cmc commented Oct 31, 2024

Yep, confirmed that. Okay that should be a one liner then 👀

@teh-cmc teh-cmc self-assigned this Oct 31, 2024
@teh-cmc teh-cmc mentioned this issue Oct 31, 2024
Merged
50 tasks
@teh-cmc
Copy link
Member

teh-cmc commented Oct 31, 2024

The problem is trivial, and you'd hope the fix would be too... but then SetStoreInfo gets involved, and that's when you know all bets are off 🫠

I have something that's 99% there, but I'll need to finish another time as it gets mind-bendingly complex even though it has absolutely no right to...

teh-cmc added a commit that referenced this issue Nov 6, 2024
@teh-cmc @emilk
Consistent open/import/log_file behaviors in all common scenarios (#7966
9a5b36a 
)

All the major data-loading paths now behave sanely and consistently on
both native and web.

You can try and look at the matrix below for the specific behavior of
each path, but really my advice would be to just play with it to get a
sense of things.

One of these days we'll clearly need a bottom-up in-hindsight
refactoring for all these things, it is _so_ complex.
But today is not that day.

* Fixes #7965 

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
None yet
Projects
None yet
Milestone
0.20 - Maps, H.264
Development

Successfully merging a pull request may close this issue.

Consistent open/import/log_file behaviors in all common scenarios rerun-io/rerun
2 participants
@emilk @teh-cmc