Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all items in override UI always apply to visualizers #6595

Closed
23 of 26 tasks
jleibs opened this issue Jun 19, 2024 · 5 comments
Closed
23 of 26 tasks

Not all items in override UI always apply to visualizers #6595

jleibs opened this issue Jun 19, 2024 · 5 comments
Assignees
Labels
ui concerns graphical user interface
Milestone

Comments

@jleibs
Copy link
Member

jleibs commented Jun 19, 2024

The value shown can be confusing and the fact that modifying it does nothing is more-so confusing.

@jleibs jleibs added this to the 0.17 milestone Jun 19, 2024
@Wumpf
Copy link
Member

Wumpf commented Jun 28, 2024

left some notes from slack conversations on various items

@emilk emilk added the ui concerns graphical user interface label Jul 1, 2024
@Wumpf Wumpf self-assigned this Jul 1, 2024
teh-cmc pushed a commit that referenced this issue Jul 2, 2024
### What

* Part of #6595

All color fallback value juggling is now more or less forced to go
through a (typed) fallback provider.
This way, the ui can query the fallback as well, even when it's not in
use.

The "structure" of the helix demo has an orang'ish fallback but is set
grey via store:
<img width="192" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/9a868c2d-afdf-4b00-8d70-6e2523bd8d61">
teh-cmc pushed a commit that referenced this issue Jul 2, 2024
…es (#6712)

### What

First commit wires the `TextLogView` to the override system. Making this
part of:

* #6595

Second commit makes us handle static text without errors. Allowing
non-catastrophic behavior when changing the text message:

Text run using:
```py
import rerun as rr

rr.init("rerun_example_text_log", spawn=True)

rr.set_time_seconds("t", 0.0)
rr.log("log", rr.TextLog("Application started.", level=rr.TextLogLevel.INFO))
rr.set_time_seconds("t", 0.1)
rr.log("log", rr.TextLog("Application wumpfed.", level=rr.TextLogLevel.WARN))
rr.set_time_seconds("t", 100.0)
rr.log("log", rr.TextLog("Thing happening", color=0xFF9001FF, level=rr.TextLogLevel.ERROR))
```


https://github.com/rerun-io/rerun/assets/1220815/5c364ca2-65d2-4626-862e-e60ce70cfdaf
teh-cmc added a commit that referenced this issue Jul 2, 2024
Wumpf added a commit that referenced this issue Jul 2, 2024
### What

* mentioned in #6595

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6718?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6718?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6718)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
teh-cmc pushed a commit that referenced this issue Jul 2, 2024
### What

* Part of #6595

And because it was so easy, the fallback for the tensor in the bar chart
is now meaningfully adjusted!


https://github.com/rerun-io/rerun/assets/1220815/9bc9e179-ef1e-4996-9611-b9dd0bb5d53e
@Wumpf
Copy link
Member

Wumpf commented Jul 2, 2024

Suggestions for resolving the label issue:

  • link to an issue from Text component where we describe the issue in details
  • document hiding behavior on Text component so it shows up on the tooltip (careful: it's used in places where this does not apply)
  • maybe: increase hiding threshhold, experiment!

@Wumpf
Copy link
Member

Wumpf commented Jul 2, 2024

Suggestions for resolving depth meter issue:

  • open an issue about problematic visualizer sharing between 2D/3D on the example of DepthImage. One solution is to split DepthImage (?) and DepthImage (or DepthImage2D/DepthImage3D). Another thread of solutions is "View in View"
  • improve documentation on depth image archetype
  • add note on FillRatio
  • add note on limited effected of DepthMeter (it's not nothing, but close ;))

@Wumpf
Copy link
Member

Wumpf commented Jul 3, 2024

label was resolved differently, we now place single labels at the center of visualizations

Wumpf added a commit that referenced this issue Jul 4, 2024
…ews (#6745)

### What

* Part of #6595

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6745?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6745?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6745)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Wumpf added a commit that referenced this issue Jul 4, 2024
…abel now at the center (#6741)

### What

Previously, single labels would splat out, quickly hitting the "can't
display more labels" limit (described in #3465).
Now, there's a special meaning for a single labels: Instead of splatting
it across all instances, we place the single label at the center.

This is particularly useful with in-viewer overrides, as it allows to
set labels on objects with many instances.

![image](https://github.com/rerun-io/rerun/assets/1220815/a4e2462f-3fee-4cca-a4bd-d05cff263621)

A drawback of bounding box based placement is that the label moves with
the box. But I reckon it's a lot better than the alternative.

https://github.com/rerun-io/rerun/assets/1220815/866058a4-8edf-4ce7-9cd5-63f8b00e34a3

* Part of #6595

### Checklist

* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6741?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6741?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6741)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@Wumpf
Copy link
Member

Wumpf commented Jul 4, 2024

all addressed, mitigated or filed separately!

@Wumpf Wumpf closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants