Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu: hide/don't show tooltips while a context menu is visible #5310

Closed
abey79 opened this issue Feb 27, 2024 · 2 comments · Fixed by #5416
Closed

Context menu: hide/don't show tooltips while a context menu is visible #5310

abey79 opened this issue Feb 27, 2024 · 2 comments · Fixed by #5416
Assignees
@emilk @abey79
Labels
😤 annoying Something in the UI / SDK is annoying to use ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Feb 27, 2024 •
edited
Loading

Don't show (or hide if already shown) hover tooltip when displaying a context menu. This is currently very annoying.

To be solved in egui?

image
@abey79 abey79 added the ui concerns graphical user interface label Feb 27, 2024
@abey79 abey79 added the 😤 annoying Something in the UI / SDK is annoying to use label Feb 27, 2024
This was referenced Mar 5, 2024
Merged
Merged
@abey79
Copy link
Member Author

abey79 commented Mar 5, 2024

egui fix in emilk/egui#4138

abey79 added a commit that referenced this issue Mar 6, 2024
@abey79
More context menu 2: add support to show/hide DataResults (#5397)
e77b518 
### What

The `Hide` and `Show` actions now support `DataResult`s as well.

With that, it's easier than ever to run into:
- #5396
- #5310

<img width="313" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/d6ee0b27-3438-4c95-b60d-7ed95ca26061">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5397/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5397/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5397/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5397)
- [Docs
preview](https://rerun.io/preview/5fb3cb84bb6be6f6b133dd82e2d2a19b9d9ce4a9/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/5fb3cb84bb6be6f6b133dd82e2d2a19b9d9ce4a9/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf pushed a commit to emilk/egui that referenced this issue Mar 6, 2024
@abey79
Hide hover UI when showing the context menu (#4138)
a1d5145 
This PR hides the hover UI for a given widget whenever a corresponding
context menu is opened.

Fixes:
- rerun-io/rerun#5310
abey79 added a commit that referenced this issue Mar 6, 2024
@abey79
Bump egui master
093db3f 
Fixes #5310
@abey79 abey79 mentioned this issue Mar 6, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue Mar 7, 2024
@abey79
Bump egui master (#5416)
532d047 
### What

Fixes #5310 thanks to emilk/egui#4138

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5416/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5416/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5416/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5416)
- [Docs
preview](https://rerun.io/preview/093db3f095155bbdf42cfc9a25593fa1be8e13de/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/093db3f095155bbdf42cfc9a25593fa1be8e13de/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@emilk
Copy link
Member

emilk commented Mar 11, 2024

nice one

@emilk emilk mentioned this issue Apr 8, 2024
Closed
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@abey79 @hacknus
Hide hover UI when showing the context menu (emilk#4138)
4f63d39 
This PR hides the hover UI for a given widget whenever a corresponding
context menu is opened.

Fixes:
- rerun-io/rerun#5310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

@abey79 abey79

Labels
😤 annoying Something in the UI / SDK is annoying to use ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump egui master rerun-io/rerun
2 participants
@emilk @abey79