Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify behavior of aggregation properties in plots #4954

Closed
Tracked by #4813
jleibs opened this issue Jan 29, 2024 · 0 comments · Fixed by #4987
Closed
Tracked by #4813

Clarify behavior of aggregation properties in plots #4954

jleibs opened this issue Jan 29, 2024 · 0 comments · Fixed by #4987
Assignees
@Wumpf
Labels
📖 documentation Improvements or additions to documentation ui concerns graphical user interface
Milestone
0.13

Comments

@jleibs
Copy link
Member

jleibs commented Jan 29, 2024

The entity properties for sub-pixel aggregation are called "Aggregation" leading to potential confusion with future data-analysis-style features like windowed aggregation functions.

This is explained in the hover, but not immediately apparent just based on the name.
@jleibs jleibs added 📖 documentation Improvements or additions to documentation ui concerns graphical user interface labels Jan 29, 2024
@jleibs jleibs mentioned this issue Jan 29, 2024
Open
14 tasks
@jleibs jleibs added this to the 0.13 milestone Jan 29, 2024
@Wumpf Wumpf mentioned this issue Jan 31, 2024
Merged
4 tasks
emilk pushed a commit that referenced this issue Feb 1, 2024
@Wumpf
Clarify aggregation strings (#4987)
f321da9 
### What

* Fixes #4954
* Related to #4969

on hover plot:

![image](https://github.com/rerun-io/rerun/assets/1220815/f1583f64-42a6-4517-af4d-ad2fed1b2b06)

on hover settings:

![image](https://github.com/rerun-io/rerun/assets/1220815/0d5d2256-80a4-4a88-b370-5c5afa7a126c)


Also, made it default to `MinMaxAverage` since this looks better on all
my screens for smooth lines.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4987/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4987/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4987/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4987)
- [Docs
preview](https://rerun.io/preview/141491880209d44706b04425ff8643f7e8dca9ef/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/141491880209d44706b04425ff8643f7e8dca9ef/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
📖 documentation Improvements or additions to documentation ui concerns graphical user interface
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Clarify aggregation strings rerun-io/rerun
2 participants
@Wumpf @jleibs