-
Notifications
You must be signed in to change notification settings - Fork 292
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust SDK silently drops data in some situations #2627
Comments
Adding a call to We should at least warn when data is being silently lost, and document the behavior properly. Maybe we could make |
Yeah, I think the most user-friendly solution here would be to do the same thing we do in the jupyter notebook internals in Python, namely: internally keep track of the It's a bit blurry how all of this works though, I'll have a quick look to see what's possible. |
Fixes #2627 Should supersede #2630 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2632) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2632) - [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fautoflushmagix/docs) - [Examples preview](https://rerun.io/preview/pr%3Acmc%2Fautoflushmagix/examples)
…memory sink (#2630) See: * #2627 I added some log warnings too, but they are not sufficient. If there is no call to `flush_blocking`, data is still silently dropped somehow. Maybe @teh-cmc has some idea where? ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2630) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2630) - [Docs preview](https://rerun.io/preview/pr%3Aemilk%2Fdocument-flush/docs) - [Examples preview](https://rerun.io/preview/pr%3Aemilk%2Fdocument-flush/examples)
Minimal reproduce:
Results in this:
Seems like data is lost somehow. Some flushing that is not being done?
The text was updated successfully, but these errors were encountered: