Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug v0.2.0: Id clash when using multiple Trees #11

Closed
tosti007 opened this issue Jul 6, 2023 · 0 comments · Fixed by #32
Closed

Bug v0.2.0: Id clash when using multiple Trees #11

tosti007 opened this issue Jul 6, 2023 · 0 comments · Fixed by #32

Comments

@tosti007
Copy link
Contributor

tosti007 commented Jul 6, 2023

With the release of v0.2.0, it is not longer possible to create multiple Trees within a single frame, as this results in id clashes. With v0.1.0 this wasn't an issue.

In the specific case I'm having, I have three Tabbed containers, the id clash egui gives me is on the first Tab button of each Tree Container.
@tosti007 tosti007 changed the title Bug: Id clash when using multiple Trees Bug v0.2.0: Id clash when using multiple Trees Jul 6, 2023
This was referenced Jul 24, 2023
Closed
Open
tosti007 added a commit to Traverse-Research/egui_tiles that referenced this issue Nov 2, 2023
@tosti007
rerun-io#12: Fix rerun-io#11: Id clash when using multiple Trees
1d7ac1e
tosti007 added a commit to Traverse-Research/egui_tiles that referenced this issue Nov 3, 2023
@tosti007
rerun-io#12: Fix rerun-io#11: Id clash when using multiple Trees
a40f9a2
@emilk emilk mentioned this issue Nov 21, 2023
Merged
@emilk emilk closed this as completed in #32 Nov 21, 2023
emilk added a commit that referenced this issue Nov 21, 2023
@emilk @tosti007
Fix Id clash when using multiple Trees (#32)
7a3991d 
* Closes #11 

* (this is a fork of #12)

---

Each `Tree` now has a globally unique id, meaning the same `Tree` can be
rendered in different `Ui`:s and still work, and you can have multiple
trees. However, it is up to the user to pick a globally unique id.

---------

Co-authored-by: tosti007 <git@brianjanssen.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Id clash when using multiple Trees rerun-io/egui_tiles
1 participant
@tosti007