Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(circulation): automatic loan renewal #3691

Merged
merged 1 commit into from
Jul 4, 2024
Merged

feat(circulation): automatic loan renewal #3691

merged 1 commit into from
Jul 4, 2024

Conversation

PascalRepond
Copy link
Contributor

  • Adds circ_policy field to set automatic renewals.
  • Adds daily task to automatically renew loans on their due date when they are renewable.
  • Adds a new type of notification "auto_extend" to be sent to the patron when a loan is automatically extended.

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: notifications f: search f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test dev: DB Database structure (models.py) labels May 27, 2024
rerowep
rerowep approved these changes May 27, 2024
View reviewed changes
Garfield-fr
Garfield-fr reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@Garfield-fr Garfield-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a PR for the UI?

@Garfield-fr Garfield-fr self-requested a review May 28, 2024 06:06
@PascalRepond
Copy link
Contributor Author

PascalRepond commented May 28, 2024 •
edited
Loading

Will there be a PR for the UI?

@Garfield-fr I think not needed, or maybe just a manual translation for a field in library editor. To be tested.

@github-actions github-actions bot added the f: activity-logs Everything around logging user or system activities label May 28, 2024
@PascalRepond PascalRepond force-pushed the rep-renewals branch 6 times, most recently from b37fea0 to ed4abb6 Compare May 29, 2024 07:50
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request May 29, 2024
@PascalRepond
feat(circulation): automatic renewals
dbb7238 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adapts the library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this pull request May 29, 2024
Merged
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request May 29, 2024
@PascalRepond
feat(circulation): automatic renewals
74c04a1 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adapts the library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond deleted the rep-renewals branch June 3, 2024 11:51
@PascalRepond PascalRepond restored the rep-renewals branch June 13, 2024 11:32
@PascalRepond PascalRepond reopened this Jun 13, 2024
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Jun 13, 2024
@PascalRepond
feat(circulation): automatic renewals
3fdb9e1 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adapts the library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Jun 13, 2024
@PascalRepond
feat(circulation): automatic renewals
76ae095 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adds new notification type so that it can be displayed in the
library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Jun 13, 2024
@PascalRepond
feat(circulation): automatic renewals
6719562 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adds new notification type so that it can be displayed in the
library editor.
* Fixes the notification type `claim_issue` being wrongly displayed in
the library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to rero/rero-ils-ui that referenced this pull request Jul 1, 2024
@PascalRepond
feat(circulation): automatic renewals
3a2297c 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adds new notification type so that it can be displayed in the
library editor.
* Fixes the notification type `claim_issue` being wrongly displayed in
the library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond @jma
feat(circulation): automatic loan renewal
a35921b 
* Adds circ_policy field to set automatic renewals.
* Adds daily task to automatically renew loans on their due date when
they are renewable.
* Adds a new type of notification "auto_extend" to be sent to the patron
when a loan is automatically extended.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
@PascalRepond PascalRepond merged commit 7ecf5ba into rero:staging Jul 4, 2024
4 checks passed
@PascalRepond PascalRepond deleted the rep-renewals branch July 4, 2024 08:05
PascalRepond added a commit to rero/rero-ils-ui that referenced this pull request Jul 8, 2024
@PascalRepond
feat(circulation): automatic renewals
95e2274 
* Depends on rero/rero-ils#3691.
* Adds the info for auto_extends in the circulation log.
* Adds new notification type so that it can be displayed in the
library editor.
* Fixes the notification type `claim_issue` being wrongly displayed in
the library editor.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@rerowep rerowep rerowep approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
dev: DB Database structure (models.py) dev: fixtures Fixtures data used for ils.test and ilsdev.test f: activity-logs Everything around logging user or system activities f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: notifications f: search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalRepond @Garfield-fr @rerowep