Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facet: fix year #3605

Merged
merged 1 commit into from
Apr 2, 2024
Merged

facet: fix year #3605

merged 1 commit into from
Apr 2, 2024

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 19, 2024

  • Fixes year facet for imports.
  • Better publication year facet for documents.

@rerowep rerowep self-assigned this Feb 19, 2024
@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Feb 19, 2024
@rerowep rerowep marked this pull request as draft February 20, 2024 08:07
@rerowep rerowep marked this pull request as ready for review February 25, 2024 07:37
@rerowep rerowep force-pushed the wep-fix-year-facet branch from 2b18eb8 to f4480f6 Compare March 4, 2024 06:50
@rerowep rerowep requested a review from PascalRepond March 4, 2024 06:50
@rerowep rerowep force-pushed the wep-fix-year-facet branch 2 times, most recently from 39415a9 to db9d017 Compare March 4, 2024 06:54
@rerowep rerowep force-pushed the wep-fix-year-facet branch 2 times, most recently from b09018d to 2a4b5f8 Compare March 4, 2024 09:24
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are missing

@rerowep rerowep force-pushed the wep-fix-year-facet branch 3 times, most recently from 5c6e735 to 0cd0060 Compare March 6, 2024 08:41
@rerowep rerowep requested a review from jma March 6, 2024 08:41
@rerowep rerowep force-pushed the wep-fix-year-facet branch from 0cd0060 to 4d461a2 Compare March 18, 2024 07:30
* Fixes year facet for imports.
* Better publication year facet for documents.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep force-pushed the wep-fix-year-facet branch from 4d461a2 to d858f3a Compare March 26, 2024 07:46
@rerowep rerowep merged commit df629e2 into rero:staging Apr 2, 2024
4 checks passed
@rerowep rerowep deleted the wep-fix-year-facet branch April 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants