-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
facet: fix year #3605
Merged
Merged
facet: fix year #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rerowep
commented
Feb 19, 2024
- Fixes year facet for imports.
- Better publication year facet for documents.
7c73954
to
a756c48
Compare
028b086
to
828770e
Compare
a756c48
to
a7af502
Compare
828770e
to
4e9315e
Compare
a7af502
to
2b18eb8
Compare
PascalRepond
requested changes
Feb 29, 2024
2b18eb8
to
f4480f6
Compare
39415a9
to
db9d017
Compare
PascalRepond
requested changes
Mar 4, 2024
b09018d
to
2a4b5f8
Compare
PascalRepond
approved these changes
Mar 4, 2024
lauren-d
approved these changes
Mar 4, 2024
jma
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are missing
5c6e735
to
0cd0060
Compare
0cd0060
to
4d461a2
Compare
* Fixes year facet for imports. * Better publication year facet for documents. Co-Authored-by: Peter Weber <peter.weber@rero.ch>
4d461a2
to
d858f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: data
About data model, importation, transformation, exportation of data, specific for bibliographic data
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.