Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item: add library name on the circulation dump #3549

Merged

Conversation

Garfield-fr
Copy link
Contributor

No description provided.

@Garfield-fr Garfield-fr self-assigned this Dec 4, 2023
@Garfield-fr Garfield-fr force-pushed the zub-item-add-library-name-sort branch from 5c10bcf to 7fe84e3 Compare December 4, 2023 11:05
@Garfield-fr Garfield-fr marked this pull request as ready for review December 4, 2023 13:32
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing.

Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR if @jma comment is integrated ;-)

@Garfield-fr Garfield-fr force-pushed the zub-item-add-library-name-sort branch from 7fe84e3 to 9953218 Compare December 6, 2023 09:45
@Garfield-fr Garfield-fr requested a review from jma December 6, 2023 09:46
@Garfield-fr Garfield-fr force-pushed the zub-item-add-library-name-sort branch from 9953218 to 21e8182 Compare December 6, 2023 09:52
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-item-add-library-name-sort branch from 21e8182 to feecfc3 Compare December 6, 2023 09:57
@Garfield-fr Garfield-fr merged commit c7e975b into rero:staging Dec 6, 2023
@Garfield-fr Garfield-fr deleted the zub-item-add-library-name-sort branch December 11, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants