Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entities: fix replace identified by #3413

Merged
merged 1 commit into from
Jul 25, 2023
Merged

entities: fix replace identified by #3413

merged 1 commit into from
Jul 25, 2023

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jul 22, 2023

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@rerowep
entities: fix replace identified by
45b953a 
Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep self-assigned this Jul 22, 2023
zannkukai
zannkukai approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to limit work on Entities resources. Each time, we need to do a rebase and be aware to not forget any changes because this file has been moved and so doesn't have any conflicts. Each time, it's an huge work

@rerowep rerowep merged commit 1159cd1 into rero:staging Jul 25, 2023
@rerowep rerowep deleted the wep-fix-replace branch July 28, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@zannkukai zannkukai zannkukai approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @Garfield-fr @zannkukai @PascalRepond