Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sru: subjects and genreForm #3365

Merged
merged 1 commit into from
Jun 28, 2023
Merged

sru: subjects and genreForm #3365

merged 1 commit into from
Jun 28, 2023

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jun 7, 2023

  • Corrects XML namespace.
  • Adds subjects bf:Person, bf:Organisation, bf:Topic, bf:Work, bf:Place.
  • Adds genreForm

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@rerowep rerowep self-assigned this Jun 7, 2023
@github-actions github-actions bot added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Jun 7, 2023
@rerowep rerowep force-pushed the wep-sru-subjects branch 5 times, most recently from cf4af12 to 9290739 Compare June 8, 2023 10:08
zannkukai
zannkukai reviewed Jun 8, 2023
View reviewed changes
@rerowep rerowep force-pushed the wep-sru-subjects branch from 9290739 to e9830e9 Compare June 12, 2023 06:03
@rerowep rerowep requested a review from zannkukai June 12, 2023 06:03
jma
jma requested changes Jun 12, 2023
View reviewed changes
@PascalRepond PascalRepond mentioned this pull request Jun 7, 2023
Closed
@rerowep rerowep force-pushed the wep-sru-subjects branch 2 times, most recently from 1f6b088 to 0ea12dc Compare June 15, 2023 12:43
@rerowep rerowep requested a review from jma June 15, 2023 13:11
@rerowep rerowep force-pushed the wep-sru-subjects branch from 0ea12dc to b9a9b44 Compare June 16, 2023 07:11
@rerowep rerowep force-pushed the wep-sru-subjects branch from b9a9b44 to 66646fd Compare June 28, 2023 06:00
@rerowep
sru: subjects and genreForm
215e268 
* Corrects XML namespace.
* Adds subjects bf:Person, bf:Organisation, bf:Topic, bf:Work, bf:Place.
* Adds genreForm

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep force-pushed the wep-sru-subjects branch from 66646fd to 215e268 Compare June 28, 2023 09:23
@rerowep rerowep merged commit bb77b35 into rero:staging Jun 28, 2023
@rerowep rerowep deleted the wep-sru-subjects branch June 28, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@zannkukai zannkukai zannkukai approved these changes

@lauren-d lauren-d lauren-d approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@benerken benerken Awaiting requested review from benerken

Assignees

@rerowep rerowep

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @jma @zannkukai @lauren-d @PascalRepond