Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General note label displayed even if the field doesn't exist #3523

Closed
PascalRepond opened this issue Nov 13, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1075
Closed

General note label displayed even if the field doesn't exist #3523

PascalRepond opened this issue Nov 13, 2023 · 0 comments · Fixed by rero/rero-ils-ui#1075
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: professional ui Professional interface UX User experience, ergonomy

Comments

@PascalRepond
Copy link
Contributor

PascalRepond commented Nov 13, 2023 •
edited
Loading

Bug description:

In the professionnal detailed view of some documents. The label "General note" is displayed even though the field doesn't exist.

Expected behavior:

When a field doesn't exist, the label in the description should not be displayed.

Steps to Reproduce:

Example : https://bib.rero.ch/professional/records/documents/detail/2193979
It seems this only happens for documents that do not contain any note subfield. If another type of note is present, the "general note" label is not shown.

Other remarks

See conditions in https://github.com/rero/rero-ils-ui/blob/staging/projects/admin/src/app/record/detail-view/document-detail-view/document-description/document-description.component.ts#L139-L155

Context

  • Versions: v1.19.0
@PascalRepond PascalRepond added f: professional ui Professional interface bug Breaks something but is not blocking UX User experience, ergonomy client request Issue reported by production libraries labels Nov 13, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Nov 13, 2023
@Garfield-fr Garfield-fr self-assigned this Nov 15, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to In Development in RERO ILS issues Nov 15, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Nov 15, 2023
@Garfield-fr
documents: fix notes display
47216b1 
* Closes rero/rero-ils#3523.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Nov 15, 2023
Merged
@Garfield-fr Garfield-fr moved this from In Development to Ready to test in RERO ILS issues Nov 15, 2023
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Nov 21, 2023
@Garfield-fr @PascalRepond
documents: fix notes display
02bdd2b 
* Closes rero/rero-ils#3523.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: professional ui Professional interface UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: fix notes display Garfield-fr/rero-ils-ui
2 participants
@Garfield-fr @PascalRepond