Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login location not displayed if only one affiliation #3477

Closed
ManaDeweerdt opened this issue Oct 3, 2023 · 2 comments · Fixed by rero/rero-ils-ui#1058
Closed

Login location not displayed if only one affiliation #3477

ManaDeweerdt opened this issue Oct 3, 2023 · 2 comments · Fixed by rero/rero-ils-ui#1058
Assignees
@Garfield-fr
Labels
correction An implemented feature doesn't work as expected. effort: minor Solved quickly f: professional ui Professional interface

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Oct 3, 2023 •
edited by PascalRepond
Loading

How it works

For now, if a librarian has only one affiliated library, the login location is not displayed.

Improvement suggestion

Display the library-switch menu for all profesionnal users even when there is only one library.

image
@ManaDeweerdt ManaDeweerdt added f: professional ui Professional interface correction An implemented feature doesn't work as expected. labels Oct 3, 2023
@PascalRepond
Copy link
Contributor

What is the use case for this? It seems not a very useful information to display.

@ManaDeweerdt
Copy link
Contributor Author

ManaDeweerdt commented Oct 3, 2023 •
edited
Loading

What is the use case for this? It seems not a very useful information to display.

We had an issue with a librarian with the wrong location. It is better if the library is displayed to avoid possible error of editing.

@PascalRepond PascalRepond added the effort: minor Solved quickly label Oct 3, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Oct 3, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 10, 2023
@Garfield-fr
library switch: always show the menu
61b241f 
* Closes rero/rero-ils#3477.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr self-assigned this Oct 10, 2023
@Garfield-fr Garfield-fr moved this from Product Backlog to Ready to test in RERO ILS issues Oct 10, 2023
@Garfield-fr Garfield-fr mentioned this issue Oct 10, 2023
Merged
7 tasks
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Oct 26, 2023
@Garfield-fr
library switch: always show the menu
beef90a 
* Closes rero/rero-ils#3477.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@PascalRepond PascalRepond moved this from Ready to test to Approved in RERO ILS issues Oct 31, 2023
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 31, 2023
@Garfield-fr
library switch: always show the menu
2b2e995 
* Closes rero/rero-ils#3477.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
correction An implemented feature doesn't work as expected. effort: minor Solved quickly f: professional ui Professional interface
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

library switch: always show the menu Garfield-fr/rero-ils-ui
3 participants
@Garfield-fr @ManaDeweerdt @PascalRepond