Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serials: items that are not received should not have a received_date #3457

Closed
PascalRepond opened this issue Sep 7, 2023 · 0 comments · Fixed by #3522
Closed

Serials: items that are not received should not have a received_date #3457

PascalRepond opened this issue Sep 7, 2023 · 0 comments · Fixed by #3522
Assignees
@rerowep
Labels
correction An implemented feature doesn't work as expected. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: serials

Comments

@PascalRepond
Copy link
Contributor

How it works

Serial items can currently have an issue.received_date field even when their issue.status is not RECEIVED. This is inconsistent data.

When an issue becomes late, it is created by the system through the receive_regular_issue function which adds a received_date. Then, the status is changed to LATE but the issue.received_date field is kept.

Improvement suggestion

  • Fix the behavior for issue management by the system so that it never saves a not received item with a received_date
  • Add data validation if necessary
  • Add tests
@PascalRepond PascalRepond added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: serials correction An implemented feature doesn't work as expected. labels Sep 7, 2023
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Sep 7, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Sprint backlog in RERO ILS issues Oct 31, 2023
@PascalRepond PascalRepond moved this from Sprint backlog to Product Backlog in RERO ILS issues Nov 6, 2023
@rerowep rerowep moved this from Product Backlog to In Development in RERO ILS issues Nov 9, 2023
@rerowep rerowep self-assigned this Nov 9, 2023
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 9, 2023
@rerowep
items: fix late issue
50b2675 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep moved this from In Development to Ready to test in RERO ILS issues Nov 9, 2023
@rerowep rerowep mentioned this issue Nov 9, 2023
Merged
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 14, 2023
@rerowep
items: fix late issue
6426dca 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 20, 2023
@rerowep
items: fix late issue
ee696d6 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 21, 2023
@rerowep
items: fix late issue
980a76b 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 21, 2023
@rerowep
items: fix late issue
303fbe0 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 21, 2023
@rerowep
items: fix late issue
06c1682 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 21, 2023
@rerowep
items: fix late issue
7ba9415 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue Nov 21, 2023
@rerowep
items: fix late issue
f598935 
* Deletes `received_date` from issue if LATE.
* Closes: rero#3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@github-project-automation github-project-automation bot moved this from Ready to test to Done in RERO ILS issues Nov 23, 2023
rerowep added a commit that referenced this issue Nov 23, 2023
@rerowep
items: fix late issue
cc63432 
* Deletes `received_date` from issue if LATE.
* Closes: #3457.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
correction An implemented feature doesn't work as expected. f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: serials
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

items: fix late issue rerowep/rero-ils
2 participants
@rerowep @PascalRepond