Trigger page load listeners when complete or no longer loading #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port changes from jQuery Related to requirejs#1 requirejs#18
|
|
ihor-sviziev
changed the title
|
@jrburke could you review my PR? |
|
Thank you for taking time to make a pull request, and I apologize for not responding earlier. This seems to be different than the latest master of jQuery: https://github.com/jquery/jquery/blob/master/src/core/ready.js#L64. That said, I'm not really set up to track fixes for IE6-10 issues, and I have not really maintained this repo over the last couple of years. Will close, mostly due to my own lack of maintaining the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequireJS domReady is used in Magento 2, and it was causing following issue magento/magento2#22909, so in Magento there was added local fix on top of this library magento/magento2#23313.
I'd like to submit a fix for this issue to the library itself in order to have ability just update it to latest version and resolve the issue for everyone.
After checking alternatives I found that jQuery has compatible with older IE versions solution, so I think it's better to apply it.
This is port from jQuery jquery/jquery@8c293e6 that supports old IE versions.
Fixes #18.
Related to #1