Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless Buffer transformation #1733

Merged
merged 1 commit into from
Aug 18, 2015

Conversation

michelsalib
Copy link

The implementation is very naive and aim to solve #1732.

I am not sure about writing tests as I am not fluent with tape. If necessary I can try spend time on it.

@simov
Copy link
Member

simov commented Aug 17, 2015

👍 I like the Buffer.byteLength touch will merge it shortly.

@michelsalib
Copy link
Author

Can I help making this go forward?

simov added a commit that referenced this pull request Aug 18, 2015
Avoid useless Buffer transformation
@simov simov merged commit 51b55ac into request:master Aug 18, 2015
@simov
Copy link
Member

simov commented Aug 18, 2015

Generally we're waiting at least 24 hours before merging a PR. Anyway, do you want me to publish new version on NPM?

@michelsalib
Copy link
Author

Maybe you have another batch of fix to merge. Let's wait tomorrow before publishing to npm.

@michelsalib
Copy link
Author

We are good to make an npm release?

@simov
Copy link
Member

simov commented Aug 19, 2015

Yep, I was looking at another PR, but I don't feel comfortable merging it yet. Anyway, 2.61 is published on NPM.

@michelsalib
Copy link
Author

Thanks, :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants