Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update analytics module umami #6412

Closed
wants to merge 1 commit into from
Closed

feat: update analytics module umami #6412

wants to merge 1 commit into from

Conversation

cdn0x12
Copy link
Contributor

@cdn0x12 cdn0x12 commented May 5, 2023

Umami has entered the next major version, introducing a breaking change to its script structure.

See: https://umami.is/docs/migrate-v1-v2

Umami has entered the next major version, introducing a breaking change to its script structure.

See: https://umami.is/docs/migrate-v1-v2
@auto-assign auto-assign bot requested a review from NGPixel May 5, 2023 19:20
@NGPixel
Copy link
Member

NGPixel commented May 12, 2023

What if someone upgrades to the new Wiki.js version but still use v1? Will their analytics suddenly stop working?

@cdn0x12
Copy link
Contributor Author

cdn0x12 commented May 12, 2023

Yes, v2 and v1 are two incompatible versions.

If we want to allow users to choose between v1 and v2 themselves, we can either

  • create another analysis module
  • add a setting field that allows users to enter the script name (umami.js for v1 and script.js for v2)

@pxlfrk
Copy link

pxlfrk commented May 15, 2023

+1 for this update - using umami in v2 & can't track my wiki page views :)

@NGPixel
Copy link
Member

NGPixel commented May 15, 2023

A dedicated module for v2 would be preferred. There's currently no conditional capabilities for analytic modules.

@cdn0x12
Copy link
Contributor Author

cdn0x12 commented May 15, 2023

Okay, I'll close this and create another one.

@cdn0x12 cdn0x12 closed this May 15, 2023
@cdn0x12 cdn0x12 deleted the patch-1 branch May 15, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants