fix: uriencode git user/pass for http remote

requarks · Apr 22, 2020 · 4308152 · 4308152
1 parent 6bf0261
commit 4308152
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/server/modules/storage/git/storage.js b/server/modules/storage/git/storage.js
@@ -88,9 +88,9 @@ module.exports = {
         WIKI.logger.info('(STORAGE/GIT) Adding origin remote via HTTP/S...')
         let originUrl = ''
         if (_.startsWith(this.config.repoUrl, 'http')) {
-          originUrl = this.config.repoUrl.replace('://', `://${this.config.basicUsername}:${this.config.basicPassword}@`)
+          originUrl = this.config.repoUrl.replace('://', `://${encodeURI(this.config.basicUsername)}:${encodeURI(this.config.basicPassword)}@`)
         } else {
-          originUrl = `https://${this.config.basicUsername}:${this.config.basicPassword}@${this.config.repoUrl}`
+          originUrl = `https://${encodeURI(this.config.basicUsername)}:${encodeURI(this.config.basicPassword)}@${this.config.repoUrl}`
         }
         await this.git.addRemote('origin', originUrl)
         break