Add flag to get the latest release from a specified major version #12
Conversation
get-reposense.py
Outdated
| for i in releases: | ||
| release_tag = i['tag_name'] | ||
| if release_tag[:len(tag)] == tag and \ | ||
| not (release_tag[len(tag):len(tag)+1].isdigit() and tag[-1].isdigit()): |
There was a problem hiding this comment.
Nit: some tags look like v1.9rc which could match with v1.9 depending on the order of releases but are not technically official releases - in general, release versions could include non-numeric characters.
Maybe we can split by . and compare each section (or something else that makes sense)
There was a problem hiding this comment.
Hi, thanks for the review, I've updated it accordingly
|
@jedkohjk Did you intend to commit RepoSense.jar and logs? LGTM otherwise! |
Oh, I didn't notice. I've removed them. Thank you! |
|
@jedkohjk Changes in this PR does not mention the use of wild card anywhere. So, the users will not be aware that a wildcard can be used? |
|
@damithc A new flag is used instead of a wildcard for an existing flag |
So, |
|
@damithc It is mentioned in |
It says Perhaps something like the following? |
Alright, I'll do it later today (probably tonight) as I do not have access to my laptop at the moment. |
jedkohjk
changed the title
jedkohjk
changed the title
|
I've made the following 2 PRs addressing the discussion today: |
…se (#2244) The user guide section for `run.sh` requires updating after the PR to publish-RepoSense: reposense/publish-RepoSense#12 Let's update the User Guide to describe `--latest` tag in the `run.sh` section.
Resolves reposense/RepoSense#2208
Proposed commit message
Add flag to get the latest release from a specified major version
Other information
Use the flag
--latestor-land specify the major version after the flag.Was initially planning to make it as an extension of
--tagort, but parsing wildcards in the middle of strings may be complicated. It may also mean that we are unable to name versions containing*or the specific wildcard character used. Hence, I introduced a new flag instead.