-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2196] Use git blame line info for aggregate blame author modified and date info #2232
base: master
Are you sure you want to change the base?
Conversation
Hi, I have noticed that some test cases take a very long time to finish. Could this be due to the additional overhead incurred from running git blame command in blameLine? |
…meAuthorModifiedAndDateInfo
Hi, would anyone like to approve the workflow? I am not sure why the local test cases run indefinitely, so I am unable to verify that it passes all test cases. Thank you! |
done |
Hi, would anyone like to help me for this issue? I could not seem to figure why the test cases are failing. More information at this discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! Should be good to go after the final few comments are addressed.
*/ | ||
private static GitBlameLineInfo processGitBlameResultLine(String blameResult) { | ||
String[] blameResultLines = StringsUtil.NEWLINE.split(blameResult); | ||
private static GitBlameLineInfo processGitBlameResultLine(String[] blameResultLines, String timeOption) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to use a boolean for timeOption since it doesn't seem like there are likely to be new options in git in the future.
@@ -5,6 +5,9 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add / update tests for functions / flags you've added here?
…meAuthorModifiedAndDateInfo
Hi, |
This PR was closed because it has been marked as stale for 7 days with no activity. |
@logical-1985516 Are you planning to wrap up this PR and #2238? I think this PR is mostly good to merge and is just pending some updates to tests. |
…iedAndDateInfo' of https://github.com/logical-1985516/RepoSense into 2196-use-GitBlameLineInfo-for-aggregateBlameAuthorModifiedAndDateInfo
Fixes #2196
Proposed commit message
Other information
Surrounding code which states milliseconds is also changed to state seconds correctly, as this PR is meant to resolve a code quality issue anyways. If this is not ok, I can revert the last commit.