-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2184] Fix Inconsistent Line Number Colours #2185
Conversation
… into 2184-line-colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
frontend/cypress/tests/codeView/codeView_codeHighlighting.cy.js
Outdated
Show resolved
Hide resolved
frontend/cypress/tests/codeView/codeView_codeHighlighting.cy.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @sopa301!
Seems like this test case takes 2 seconds to run in the CLI which is reasonable. However, I had longer wait times (~12 seconds) when running using the automated browser for some reason. The test case also caused crashes of the Cypress app sometimes, possibly due to repeatedly getting the child elements. If this causes more issues in the future, perhaps we can consider limiting how many line numbers are tested instead of checking all of them.
This LGTM for now though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following links are for previewing this pull request:
|
Fixes #2184.
Proposed commit message
Other information