[#1817] Actions: update list of job runners environments for CI #1811
Conversation
The virtual environments for the GitHub Actions runners have been updated, with the introduction of macos-12 and ubuntu-22.04, and the deprecation of macos-10.15. Let's update the list of environments used for running the CI jobs.
| @@ -15,7 +15,7 @@ jobs: | |||
| name: ${{ matrix.os }} JDK 8 | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-18.04, ubuntu-20.04] | |||
| os: [ubuntu-18.04, ubuntu-20.04, ubuntu-22.04] | |||
There was a problem hiding this comment.
I'm not sure if we should adopt ubuntu-22.04 since it's still in beta according to the actions/virtual-environments page.
There was a problem hiding this comment.
Yup, it is in beta currently. I added this such that we can run on this version, but I will not be marking the run as a required check (i.e. it is allowed to fail but will not block the PR from being merged).
.github/workflows/integration.yml
Outdated
| @@ -173,7 +173,7 @@ jobs: | |||
| name: ${{ matrix.os }} JDK 8 | |||
| strategy: | |||
| matrix: | |||
| os: [windows-2022, windows-2019] | |||
| os: [windows-2016, windows-2019, windows-2022] | |||
There was a problem hiding this comment.
I'm not sure if we should add another Windows os for CI since this may impose additional load. Particularly because Windows CI is slower than that of Ubuntu.
There was a problem hiding this comment.
The jobs will run in parallel, so I think it does not cause the CI builds to take longer. Nonetheless, I removed it because I realized it was supposed to be deprecated by now.
dcshzj
changed the title
|
The following links are for previewing this pull request:
|
Fixes #1817.
Proposed commit message
Other information
List of available environments are given here: https://github.com/actions/virtual-environments#available-environments